One of my old churches had a giftshop in the back that would be open for about 15-20 minutes after church let out. Some church ladies would make mantillas or handmade rosaries for it, or sometimes there would be crosses or other devotional objects from our sister parish in Central America. There would be a variety of prayer booklets and some commercial statuary as well. It’s been a while, but I believe the proceeds generally went towards supplementing the budgets for parish programs, helping the sister parish, etc.
Another previous church had its own stand-alone bookstore that kept normal business hours a few blocks away from the church itself. An awesome Catholic bookstore, with both common and obscure theological texts; a wide range of statuary; vestments; a good selection of Catholic music and how-to-sing-Gregorian-chant kits; Catholic gifts for kids and teens; and other things.
It was nice to be able to browse a room full of Catholic things, instead of seeing what had ended up on the Catholic shelf of the local Borders or B&N.

And it was nice to know that the funds were going to a good cause.
It never occurred to me to put them at the same level as the Jesus-and-the-moneychangers scene. If memory serves, I believe part of the reason for the anger was that the moneychangers were cheating the templegoers. For example, sacrificial animals had to be blemish-free. Often times, when animals were brought in and examined, they would be deemed unfit for sacrifice— “But you can buy one of
these animals, and they’re okay!”

And of course, they’d be sold at an inflated cost.
I’ve also heard about having to pay your temple tax in Jewish currency, but a lot of people only had, say, Roman currency on hand. And they would charge an unfair exchange rate.